Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doubts about code generated for streetlights.yaml #77

Closed
alberto1980 opened this issue Aug 3, 2020 · 4 comments · Fixed by #88
Closed

Doubts about code generated for streetlights.yaml #77

alberto1980 opened this issue Aug 3, 2020 · 4 comments · Fixed by #88

Comments

@alberto1980
Copy link

I have some doubts about code generated with streetlights.yaml. There are some classes that I misunderstand

LightMeasured is a class that never is used in the generated code

On the other hand, handleReceiveLightMeasurement method at MessageHandlerService has this contract public void handleReceiveLightMeasurement(Message<?> message)

shouldnt it be public void handleReceiveLightMeasurement(Message message) { ???

PubishService Interface has methods like turnOn, turnOff, dimlight whose arguments are String instead of playLoad generated (TurnOnOffPlayload, DimLightPlayload). Is it right?

@github-actions
Copy link

github-actions bot commented Aug 3, 2020

Welcome to AsyncAPI. Thanks a lot for reporting your first issue.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@github-actions
Copy link

github-actions bot commented Oct 3, 2020

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 30 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions github-actions bot added the stale label Oct 3, 2020
@Tenischev
Copy link
Member

Hi @alberto1980

Regarding Message<?> message it's just a good practice to show that class is parametrizable with Generic.

Regarding the generation itself. Message classes are not used at the moment, it is for the future when template will support headers and message traits.

Also please check updated version of streetlights from the site. Soon PR will make template compatible with it.

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 0.20.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants