Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update MQTT support #58

Merged
merged 7 commits into from
Jun 23, 2020
Merged

Conversation

Tenischev
Copy link
Member

@Tenischev Tenischev commented Jun 6, 2020

Description

This is the next big update of this template.

  • Generation for MQTT server is updated here.
  • Parameters of bindings are supported.
  • Tests are provided.

Related issue(s)
Resolves #60

@Tenischev Tenischev marked this pull request as ready for review June 7, 2020 20:39
<p>

```yml
asyncapi: '2.0.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it the file you are testing mqtt support against?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derberg against very similar to this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tenischev please keep in mind that we want to avoid testing on streetlights to minimul as we already produced so many different variations of it that it is no longer an example but a Frankenstein 😄 . Not sure if you recall the slack discussion, that we want to work as much as possible on a dummy-like example that we already started crafting in generator repo. Please keep that in mind and explore switching to dummy example

@Tenischev
Copy link
Member Author

@derberg merge conflict resolved

@Tenischev Tenischev requested a review from derberg June 22, 2020 22:43
@derberg derberg merged commit 3b40c4d into asyncapi:master Jun 23, 2020
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update MQTT generation
3 participants