Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: switch to react, apiVersion 2 and newest react components #448

Merged
merged 19 commits into from
Oct 4, 2023
Merged

feat!: switch to react, apiVersion 2 and newest react components #448

merged 19 commits into from
Oct 4, 2023

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Sep 11, 2023 •
edited by derberg
Loading

BREAKING CHANGE
This PR adds a breaking change as we now this template depends on generator 1.12.0 as the minimum.

Description
This PR updates the HTML template to use react rendering and updates the template to use the new v2 apiVersion and updates the AsyncAPI react components.

Related issue(s)
Blocked by asyncapi/generator#1017
Blocked by asyncapi/asyncapi-react#766
Blocked by asyncapi/generator#1039
Blocked by asyncapi/parser-js#861
Fixes #430
Fixes #185

@jonaslagoni jonaslagoni marked this pull request as draft September 11, 2023 13:42
@jonaslagoni jonaslagoni mentioned this pull request Sep 12, 2023
Merged
@jonaslagoni jonaslagoni changed the title feat: add v3 support feat: switch to react, apiVersion 2 and newest react components Sep 13, 2023
@jonaslagoni jonaslagoni marked this pull request as ready for review September 13, 2023 07:05
jonaslagoni
jonaslagoni commented Sep 13, 2023
View reviewed changes
test/helpers/all.test.js Outdated Show resolved Hide resolved
@jonaslagoni jonaslagoni mentioned this pull request Sep 13, 2023
Merged
derberg
derberg requested changes Sep 14, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left few comments,

please also add to description that this PR resolves #185 too

package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
template/index.html.js Show resolved Hide resolved
@fmvilas fmvilas mentioned this pull request Sep 14, 2023
Closed
2 tasks
@jonaslagoni jonaslagoni changed the title feat: switch to react, apiVersion 2 and newest react components feat!: switch to react, apiVersion 2 and newest react components Sep 14, 2023
@derberg derberg mentioned this pull request Sep 28, 2023
Open
@jonaslagoni jonaslagoni mentioned this pull request Sep 29, 2023
Merged
@jonaslagoni jonaslagoni requested a review from derberg October 4, 2023 14:52
fmvilas
fmvilas previously approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jonaslagoni
Copy link
Member Author

Need your review as well @derberg 🙂

derberg
derberg reviewed Oct 4, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one small suggestion + also adjusted description a bit in regards to breaking change info, so it is clear for folks that will go into PR from release notes

.github/workflows/pr-testing-with-generator.yml Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

derberg
derberg approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!

@jonaslagoni
Copy link
Member Author

@derberg you probably need to remove the required check 🙂

@derberg
Copy link
Member

derberg commented Oct 4, 2023

yup 😄 done

@jonaslagoni
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 1fbb3ed into asyncapi:master Oct 4, 2023
11 checks passed
@jonaslagoni jonaslagoni deleted the add_v3_support branch October 4, 2023 21:30
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg derberg approved these changes

@fmvilas fmvilas fmvilas left review comments

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AsyncAPI spec v3 support in HTML-template Move to JSX renderer
5 participants
@jonaslagoni @derberg @asyncapi-bot @fmvilas @magicmatatjahu