Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lock react components version #439

Merged
merged 4 commits into from
Aug 31, 2023

Conversation

jonaslagoni
Copy link
Member

Description
This PR locks the react components to not use the 1.0.0-next.48 version which contains breaking changes for this library.

Related issue(s)
Fixes #438

fmvilas
fmvilas previously approved these changes Aug 31, 2023
@jonaslagoni
Copy link
Member Author

blocked by #440

@derberg
Copy link
Member

derberg commented Aug 31, 2023

@jonaslagoni but this is not going to work. I assume you want to make sure automated bump will not work and upgrade? it do not understand existence of ^, I mean the action responsible for the bump.

anyway, tests will not let the bump go through -> see #437

so what you're trying to solve here? stop having automated PRs like #437 ?

@jonaslagoni
Copy link
Member Author

@derberg in this repo bumps will still happen yes.

But it will make sure that people that install the library wont get the newest component library as in #438.

@derberg
Copy link
Member

derberg commented Aug 31, 2023

oh, ok, so not autobump related, thanks for clarification

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jonaslagoni
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit f10bbb2 into asyncapi:master Aug 31, 2023
@jonaslagoni jonaslagoni deleted the lock_react_components branch August 31, 2023 11:09
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.28.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: message.id is not a function
4 participants