Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add param to override react component config #363

Merged
merged 5 commits into from
Sep 8, 2022

Conversation

BTOdell
Copy link
Contributor

@BTOdell BTOdell commented Aug 19, 2022

README updated. Tests added. Sorry for the extra lines in the diff, my editor automatically formatted the files.

Description

Related issue(s)
#254

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BTOdell Awesome! We need to improve description of new parameter and I described my problem with changed logic of prepareConfiguration function. Overall great, but some things need to be addressed and fixed.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
filters/all.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@BTOdell BTOdell requested a review from magicmatatjahu August 24, 2022 00:22
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@BTOdell
Copy link
Contributor Author

BTOdell commented Aug 29, 2022

Anything else preventing this from being merged?

Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @BTOdell Sorry for such a delay!

@magicmatatjahu
Copy link
Member

/rtm

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants