Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move to synchronouse deletion of unnecessary files #321

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

magicmatatjahu
Copy link
Member

@magicmatatjahu magicmatatjahu commented Feb 2, 2022

Description

As in title. In the server-api project we have problem when someone pass singleFile parameter and due to fact that given files are removed in async mode (without waiting) we can end up with situation when someone will get generated template with these files.

@magicmatatjahu magicmatatjahu added the bug Something isn't working label Feb 2, 2022
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@magicmatatjahu
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 939d396 into asyncapi:master Feb 9, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.24.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@magicmatatjahu magicmatatjahu deleted the wait-for-remove-file branch February 9, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants