Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Title contains <span> tags around version #167

Closed
edubsi opened this issue Mar 24, 2021 · 4 comments · Fixed by #166
Closed

Title contains <span> tags around version #167

edubsi opened this issue Mar 24, 2021 · 4 comments · Fixed by #166
Labels
bug Something isn't working

Comments

@edubsi
Copy link

edubsi commented Mar 24, 2021

Describe the bug

Starting with version 0.18.0 tags are wrapping the version information.

How to Reproduce

Should always happen when a title is displayed. The Title of the tab will display MyAPI <span>1.0.0</span> e.g.

Expected behavior

The version information in the Title should not be wrapped with <span> tags.
@edubsi edubsi added the bug Something isn't working label Mar 24, 2021
@github-actions
Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.

Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@magicmatatjahu
Copy link
Member

@edubsi Hi! Sorry for late response. Currently we are unifying HTML-Template with React component in this PR #166 I fixed this bug in unification. Could you wait for it (max next 2 weeks)?

@edubsi
Copy link
Author

edubsi commented Apr 7, 2021

Hi! Yes 2 weeks should be no problem.
Thanks for the fix 👍

@magicmatatjahu magicmatatjahu mentioned this issue Apr 16, 2021
Merged
@magicmatatjahu
Copy link
Member

Fixed in @asyncapi/[email protected] @edubsi Reopen if will you found bugs, and sorry for delay 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: switch to react-component magicmatatjahu/html-template
2 participants
@edubsi @magicmatatjahu