Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.18.0 is missing hljs css #157

Closed
laat opened this issue Feb 19, 2021 · 4 comments · Fixed by #159
Closed

0.18.0 is missing hljs css #157

laat opened this issue Feb 19, 2021 · 4 comments · Fixed by #159
Labels
bug Something isn't working released

Comments

@laat
Copy link

laat commented Feb 19, 2021

Describe the bug

the html is missing hljs styles

How to Reproduce

npx @asyncapi/generator --force-write --output test \
  https://raw.githubusercontent.com/asyncapi/generator/v1.1.5/test/docs/dummy.yml \
  @asyncapi/html-template

The HTML is missing syntax highlighting in the examples

image

0.17.1 worked

this is a regression from 0.17.1, where syntax highlighting worked

npx @asyncapi/generator --force-write --output test \
  https://raw.githubusercontent.com/asyncapi/generator/v1.1.5/test/docs/dummy.yml \
  @asyncapi/[email protected]

image

@laat laat added the bug Something isn't working label Feb 19, 2021
@github-actions
Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.

Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@Theiaz
Copy link
Contributor

Theiaz commented Feb 19, 2021

Possible fix could be #159.

@derberg
Copy link
Member

derberg commented Feb 19, 2021

@laat it will be fixed as @Theiaz once we merge the fix, I checked and with the PR css is fixed:

npx @asyncapi/generator --force-write --output test   https://raw.githubusercontent.com/asyncapi/generator/v1.1.5/test/docs/dummy.yml https://github.com/Theiaz/html-template#158-use-css-imports

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 0.18.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants