Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postinstall breaks the installation of 0.17.2 #152

Closed
mikeroll opened this issue Feb 16, 2021 · 3 comments · Fixed by #153
Closed

postinstall breaks the installation of 0.17.2 #152

mikeroll opened this issue Feb 16, 2021 · 3 comments · Fixed by #153
Labels
bug Something isn't working

Comments

@mikeroll
Copy link

Describe the bug

0.17.2 and I think #149 specifically broke the package installation for me:

❯ node --version && npm --version           
v15.8.0
7.5.4

❯ npm install @asyncapi/[email protected]
npm ERR! code 127
npm ERR! path /Users/mike/work/owhealth-server/node_modules/@asyncapi/html-template
npm ERR! command failed
npm ERR! command sh -c rimraf "template/css/main.min.css" && npm run generate:atomcss && npm run generate:maincss && npm run generate:tailwind.css
npm ERR! > @asyncapi/[email protected] generate:atomcss
npm ERR! > cross-env NODE_ENV=production postcss template/css/atom-one-dark.min.css -o template/css/main.min.css
npm ERR! sh: cross-env: command not found
npm ERR! npm ERR! code 127
npm ERR! npm ERR! path /Users/mike/work/owhealth-server/node_modules/@asyncapi/html-template
npm ERR! npm ERR! command failed
npm ERR! npm ERR! command sh -c cross-env NODE_ENV=production postcss template/css/atom-one-dark.min.css -o template/css/main.min.css
npm ERR! 
npm ERR! npm ERR! A complete log of this run can be found in:
npm ERR! npm ERR!     /Users/mike/.cache/npm/_logs/2021-02-16T10_54_23_393Z-debug.log

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/mike/.cache/npm/_logs/2021-02-16T10_54_23_918Z-debug.log

Which is fair, I don't seem to have this cross-env. I'm not too familiar with npm, but it seems that this is because postinstall depends on a tool from devDependencies, which are not installed during a normal npm install.

How to Reproduce

Just try installing.

❯ npm install @asyncapi/[email protected]

Expected behavior

The package should install fine.

@mikeroll mikeroll added the bug Something isn't working label Feb 16, 2021
@github-actions
Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.

Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@mikeroll
Copy link
Author

Dupe of #151, they beat me to it :)

@derberg
Copy link
Member

derberg commented Feb 16, 2021

This is how you learn you have users 😭
sorry folks, PR opened already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants