Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add version parameter to allow version override #147

Merged
merged 2 commits into from
Feb 17, 2021
Merged

feat: add version parameter to allow version override #147

merged 2 commits into from
Feb 17, 2021

Conversation

M3lkior
Copy link
Contributor

@M3lkior M3lkior commented Feb 12, 2021 •
edited
Loading

Close #107

derberg
derberg reviewed Feb 15, 2021
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@M3lkior hey, please just update descriptions as suggested in the markdown-template

@M3lkior
Copy link
Contributor Author

M3lkior commented Feb 15, 2021

@M3lkior hey, please just update descriptions as suggested in the markdown-template

Done

@M3lkior M3lkior force-pushed the feat/add-version-parameter branch from 524406b to 3cda680 Compare February 15, 2021 17:06
@M3lkior M3lkior force-pushed the feat/add-version-parameter branch from 3cda680 to 903c223 Compare February 16, 2021 08:58
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

derberg
derberg approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@M3lkior thanks a lot 🙏🏼

just a hint for future contributions, please do not force push as it makes the review process much harder as the reviewer cannot easily see what was added after the review, and has to review entire PR once again.
You do not have to worry about the git history as we anyway always squash and merge at the end.

@M3lkior
Copy link
Contributor Author

M3lkior commented Feb 17, 2021

@M3lkior thanks a lot 🙏🏼

just a hint for future contributions, please do not force push as it makes the review process much harder as the reviewer cannot easily see what was added after the review, and has to review entire PR once again.
You do not have to worry about the git history as we anyway always squash and merge at the end.

ok @derberg :)

@derberg derberg merged commit 80600b6 into asyncapi:master Feb 17, 2021
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg derberg approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a param to allow version override
3 participants
@M3lkior @asyncapi-bot @derberg