Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rendering of list items in markdown #146

Merged
merged 3 commits into from
Feb 12, 2021
Merged

fix: rendering of list items in markdown #146

merged 3 commits into from
Feb 12, 2021

Conversation

Theiaz
Copy link
Contributor

@Theiaz Theiaz commented Feb 12, 2021

Description
Due to the migration from tailwind v0.x to v2.x changed its default styling for lists (see here). This does not affect the UI in general (like the <ul>in the sidebar), because list items were already rendered without bullet points. However, source from markup code should be displayed with bullet points and be intended.

Related issue(s)
Resolves #142

@Theiaz Theiaz changed the title 142 bullet point rendering fix: Bullet point rendering Feb 12, 2021
@Theiaz Theiaz changed the title fix: Bullet point rendering fix: bullet point rendering Feb 12, 2021
@Theiaz Theiaz changed the title fix: bullet point rendering fix: Rendering of list items in markdown Feb 12, 2021
@Theiaz Theiaz changed the title fix: Rendering of list items in markdown fix: rendering of list items in markdown Feb 12, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Theiaz all good now, thanks a lot for the fix man!

@derberg derberg merged commit e7e6629 into asyncapi:master Feb 12, 2021
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.17.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Theiaz Theiaz deleted the 142-bullet-point-rendering branch February 15, 2021 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rendering of CommonMark does not produce expected output
3 participants