feat: add better logging for mqtt

[kaushik-rishi]

Description

• Better MQTT logging, for subscription on topics
• More logging suggestions welcome
  
  

Related issue(s)
Resolves #406

[kaushik-rishi]

@KhudaDad414 I have a couple of doubts 🙂

1. I didn't understand what you mean't by adding error handling logic here https://github.com/asyncapi/glee/blob/master/src/adapters/mqtt/index.ts#L117
2. I did test a failure scenario using some hacky ways, but how can i actually test a failing topic subscription event ?

[KhudaDad414]

I didn't understand what you mean't by adding error handling logic here https://github.com/asyncapi/glee/blob/master/src/adapters/mqtt/index.ts#L117

I don't see any error handing logic there. 🤔

I did test a failure scenario using some hacky ways, but how can i actually test a failing topic subscription event ?

have you tried subscribing to a non-existent topic?

[kaushik-rishi]

@KhudaDad414

I don't see any error handing logic there. 🤔

This was regarding the implementation section of this #406

You've mentioned to add error handling there, so i asked what it meant 🙂

have you tried subscribing to a non-existent topic?

WDYM by a non existent topic 🤔 ? The topics are automatically being fetched from the asyncapi.yaml file right ? 🙂

[KhudaDad414]

sorry, I meant here

glee/src/adapters/mqtt/index.ts

Line 138 in bc0d45f

this.client.subscribe(channel, {

I should have used a permalink instead. 😆

WDYM by a non existent topic 🤔 ? The topics are automatically being fetched from the asyncapi.yaml file right ? 🙂

Sorry, I was thinking topics should be declared before subscribing like some other brokers. 😆
One way that I can think of is trying to subscribe with an invalid QoS in binding.

[kaushik-rishi]

@KhudaDad414

Sorry, I was thinking topics should be declared before subscribing like some other brokers. laughing One way that I can think of is trying to subscribe with an invalid QoS in binding.

I've tested things and they're working as we expected.

A couple of things i've discovered while solving this issue, which could help others

1. What's QoS ? (sort of agreement for message delivery between client and broker)
   • At most once (0)
   • At least once (1)
   • Exactly once (2).
2. Invalid binding of qos, was overriden in the library to qos 0, so can't test the error handling using qos
3. To test the error logging, i went through the mqtt package code https://github.com/mqttjs/MQTT.js/blob/main/lib/validations.js
   • this helped me to determine what topic names are invalid

[KhudaDad414]

Let's merge this. :)

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[KhudaDad414]

/rtm

[coveralls]

Pull Request Test Coverage Report for Build 5140316778

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 60.53%

---

Totals
Change from base Build 5070706381:	0.0%
Covered Lines:	324
Relevant Lines:	454

---

💛 - Coveralls

[kaushik-rishi]

@KhudaDad414 Why is this PR not being merged yet, is there any code review that i'm missing out on as this shows "Changes Requested" 🤔
I'm kind of confused.

[KhudaDad414]

Merging it right now. thanks for the contribution. @kaushik-rishi

[KhudaDad414]

/rtm

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[KhudaDad414]

/rtm

[KhudaDad414]

/rtm

[asyncapi-bot]

🎉 This PR is included in version 0.23.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀