Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): change pages to markdown #823

Merged
merged 1 commit into from
May 23, 2024
Merged

chore(ci): change pages to markdown #823

merged 1 commit into from
May 23, 2024

Conversation

Shurtu-gal
Copy link
Contributor

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9133657062

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.714%

Totals Coverage Status
Change from base Build 8965267664: 0.0%
Covered Lines: 389
Relevant Lines: 486

💛 - Coveralls

Copy link
Member

@KhudaDad414 KhudaDad414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KhudaDad414
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 7aef0fa into asyncapi:master May 23, 2024
20 checks passed
@akshatnema
Copy link
Member

@KhudaDad414 can you please revert this PR? We don't want to merge this before the migration of website is completed.

@Shurtu-gal Shurtu-gal deleted the patch-1 branch May 27, 2024 13:05
@KhudaDad414
Copy link
Member

@akshatnema sure thing. can you open a PR so I can approve it?

@Shurtu-gal For future reference, you can use /dnm or /do-not-merge command on a PR that you don't want to be merged.

@Shurtu-gal
Copy link
Contributor Author

@Shurtu-gal For future reference, you can use /dnm or /do-not-merge command on a PR that you don't want to be merged.

Sure.

Btw, The revert is not needed anymore.

@akshatnema
Copy link
Member

@KhudaDad414 Yepp, migrated website is live now, so we don't need any revert.

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.37.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants