feat: remove the reply filed support in operations #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KhudaDad414
requested review from
fmvilas,
Souvikns and
asyncapi-bot-eve
as code owners
|
afzal442
reviewed
Jan 10, 2024
| @@ -37,7 +39,7 @@ export default async function (event) { | |||
| |Attribute|Type|Description| | |||
| |---|---|---| | |||
| |send|array<[OutboundMessage](#anatomy-of-an-outbound-message)>|A list of outbound messages to send when the processing of the inbound event has finished. All clients subscribed to the given channel/topic will receive the message. | |||
| |reply|array<[OutboundMessage](#anatomy-of-an-outbound-message)>|A list of outbound messages to send as a reply when the processing of the inbound event has finished. This is useful when the target of your message is the sender of the inbound event. Note, however, that this only works when you're running Glee as a server. For example, using `reply` when receiving a WebSocket message is fine and the reply will exclusively go to the client that sent the message. However, if you're receiving a message from an MQTT broker, `reply` will work exactly the same way as `send` above, and will send the message to all the clients subscribed to the given channel/topic. | |||
There was a problem hiding this comment.
interesting, reply is no more. it turned out to be obsolete. thanks for the update
There was a problem hiding this comment.
it was cool to have it, you didn't have to specify the channel and the server that you sent the message to. but I think it's a source of confusion for now that we release version 1.0. this is something that we need for v2 of glee.
Souvikns
approved these changes
Jan 10, 2024
|
/rtm |
|
🎉 This PR is included in version 0.34.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
oviecodes
pushed a commit
to oviecodes/glee
that referenced
this pull request
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the request/reply pattern support from Glee.
Reason for Removal: Glee uses bindings for its protocols, but the current spec allows replies to different channels, complicating the required bindings for request/reply support in Glee's version 3.
Why Remove Reply Support Entirely?: To avoid confusion, we're removing the reply feature until AsyncAPI spec issue #1009 is resolved, as 'reply' has different meanings in the spec and Glee framework.