fix: add condition for token to authenticate user #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afzal442
requested review from
fmvilas,
Souvikns,
KhudaDad414 and
asyncapi-bot-eve
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
|
Hi @oviecodes I think it resolves that auth part. Can you review it? cc @Souvikns |
afzal442
changed the title
Souvikns
approved these changes
Oct 10, 2023
|
@afzal442 okay. You could use any logic to authenticate the user. Usually it would be an API call or some logic that references an authentication API. But what you've done is nice. Thanks |
|
Thanks @Souvikns @oviecodes for your reviews. I have tested it locally, it works. /rtm |
|
🎉 This PR is included in version 0.26.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #524
Removes unauthorised user to authenticate using token