-
-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support filters from external library #298
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some suggestions. Great stuff!
@fmvilas your suggestions are in, thanks! I also removed one not needed function that was left from my development. What about the config? nothing agains? should I move other config values there with this PR or? |
@fmvilas forget my last question, I'm removing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Minor stuff 👍
Co-Authored-By: Fran Méndez <[email protected]>
Co-Authored-By: Fran Méndez <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
🎉 This PR is included in version 0.41.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
filters
that accepts an array of libraries that you can additionally register as filters for your template.generator.js
is super overwhelming so using the opportunity that I worked on filters I moved them outHow to test:
./cli.js test/docs/streetlights.yml https://github.com/derberg/html-template/#use-filters-lib -o output --force-write
Migration Guide
Your templates will not work with the latest generator. In your template, in filter directory you need to refactor your functions to follow new structure or remove filters that are already extracted to https://github.com/asyncapi/generator-filters
and have this package in
package.json
dependenciesRelated issue(s)
Fixes #212