Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update relative links to api docs #1303

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

emmanuel-ferdman
Copy link
Contributor

Description
Commit bc9dbec moved the location of api.md. This PR adjusts sources to changes.

Signed-off-by: Emmanuel Ferdman <[email protected]>
Copy link

changeset-bot bot commented Oct 14, 2024

⚠️ No Changeset found

Latest commit: 9fcfc0a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link
Contributor

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually it would be better if we link to a version of the document rendered in the asyncapi.com, so https://www.asyncapi.com/docs/tools/generator/api, and it can be a relative link, like /docs/tools/generator/api

apps/generator/docs/hooks.md Outdated Show resolved Hide resolved
@derberg
Copy link
Member

derberg commented Oct 21, 2024

please also change PR title to docs: as we do not need to trigger any release here

@emmanuel-ferdman emmanuel-ferdman changed the title fix: update api guide docs: update api guide Oct 21, 2024
Copy link

@derberg derberg changed the title docs: update api guide docs: update relative links to api docs Oct 28, 2024
@derberg
Copy link
Member

derberg commented Oct 28, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit 261b66e into asyncapi:master Oct 28, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants