Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs Bug 🐞 report]: The template-constant link is broken at the generator docs #1164

Closed
1 task done
Gmin2 opened this issue Apr 1, 2024 · 6 comments
Closed
1 task done

Comments

@Gmin2
Copy link
Collaborator

Gmin2 commented Apr 1, 2024

Describe the bug you found in AsyncAPI Docs.

image

The link to the Template Context is broken. On clicking the Template Context it gives a 404 page.

Attach any resources that can help us understand the issue.

image

Code of Conduct

  • I agree to follow this project's Code of Conduct
Copy link
Contributor

github-actions bot commented Apr 1, 2024

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@lmgyuan
Copy link
Collaborator

lmgyuan commented Apr 1, 2024

May I ask if you are referring to a bug in this page: https://www.asyncapi.com/docs/tools/generator

@lmgyuan
Copy link
Collaborator

lmgyuan commented Apr 1, 2024

if so, I believe that the link should take the users to https://www.asyncapi.com/docs/tools/generator/template-context

@derberg, if my solution is correct, may I ask whether I could take this issue? I would love to fix it

@derberg
Copy link
Member

derberg commented Apr 3, 2024

@lmgyuan you're right, please go ahead with a PR

@lmgyuan
Copy link
Collaborator

lmgyuan commented Apr 3, 2024

@lmgyuan you're right, please go ahead with a PR

I have raised a PR #1170 for this!

@Gmin2
Copy link
Collaborator Author

Gmin2 commented May 23, 2024

we should close this issue @derberg

@derberg derberg closed this as completed Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants