-
-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: build and publish docker image for arm and amd platforms #1004
Conversation
Ferror
commented
Jul 3, 2023
- Use official docker github actions
- Support arm and amd architectures
- Generator version as a Dockerfile argument
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you elaborate why you need ASYNCAPI_GENERATOR_VERSION
if previous images for old versions are there anyway?
also, are you sure you want to invest in it? we will be deprecating ag
as all the CLI-related dev power goes to https://github.com/asyncapi/cli. All missing features are already there in the CLI, so pretty soon we will open an issue that address these plans
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@Ferror before I proceed I want to make sure you saw this 👇🏼
|
I also made deprecation plans official as we were so far just mentioning it is come issues/prs -> #1008 |
Yea. Deprecation doesn't mean we shouldn't add such improvement :) |
1d990b6
to
d8e8301
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ferror I saw you were force pushing something recently, but do not see any new things about delays
d8e8301
to
d0d9b45
Compare
@Ferror yo, should we keep it open? do you plan to work on it? |
@derberg I added the sleep. Personally, i dont think it will be required, but lets do little step. I have an idea how to handle more complex workflows. When there will be some space to refactor them then we can enter :) |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks man
/rtm |
🎉 This PR is included in version 1.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |