Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] : Changing from lucide-react to other alternative icon library #471

Open
2 tasks done
TenzDelek opened this issue Nov 17, 2024 · 5 comments
Open
2 tasks done
Labels
enhancement New feature or request

Comments

@TenzDelek
Copy link
Contributor

Why do we need this improvement?

currently we are having lucide react as our icon library. we are only implementing at only one place
image

currently I am implementing this #469 and was trying to use the lucide react icon for socials like github and all but it turns out that they have deprecated those
image

in light of all this limitation, I am prosposing to replace lucide and use other alternative like react icon which have a diverse set of icon compare to lucide and heroicon.

would love to hear from @AceTheCreator , @ashmit-coder about this changes.

How will this change help?

more set of diverse icon

Screenshots

No response

How could it be implemented/designed?

npm

🚧 Breaking changes

Yes

👀 Have you checked for similar open issues?

  • I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue?

Yes I am willing to submit a PR!

@TenzDelek TenzDelek added the enhancement New feature or request label Nov 17, 2024
@TenzDelek
Copy link
Contributor Author

cc @AceTheCreator , @ashmit-coder

@shivasankaran18
Copy link

can I work on this issue sir..?

@TenzDelek
Copy link
Contributor Author

no need to raise seperate pr for this. will be implemented in #469 if approved

@AceTheCreator
Copy link
Member

@TenzDelek i think using an icon library is a bit redundant for us, as we are not using a lot of them. I think using the SVG of this icons in the /illustration will be ideal, don't you think?

@TenzDelek
Copy link
Contributor Author

@TenzDelek i think using an icon library is a bit redundant for us, as we are not using a lot of them. I think using the SVG of this icons in the /illustration will be ideal, don't you think?

Agree with you, will raise a pr soon. Should we consider removing the icon library(as it will be un used) or keep it for the future sake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants