Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated twitter icon and add hover effects to footer links #225

Merged
merged 5 commits into from
Nov 23, 2023

Conversation

MahendraDani
Copy link
Contributor

Description

  • Updated the twitter icon in footer to its new logo.
  • Added hover effects to social links in the footer for better user experience.

Outcomes

asyncapi_conf_fix_223.mp4

Related issue(s)

Fixes #223

@netlify
Copy link

netlify bot commented Oct 19, 2023

Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
🔨 Latest commit 47e882f
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/655dff096313090008075ecb
😎 Deploy Preview https://deploy-preview-225--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@MahendraDani
Copy link
Contributor Author

@Mayaleeeee If there are any changes please let me know.

@AceTheCreator
Copy link
Member

cc @Mayaleeeee

@Mayaleeeee
Copy link
Member

I am on it.

@Mayaleeeee
Copy link
Member

Mayaleeeee commented Nov 9, 2023

cc @Mayaleeeee

Looks good @MahendraDani, thank you.

cc @AceTheCreator

@MahendraDani
Copy link
Contributor Author

@Mayaleeeee do I need to update this branch with the master branch?

@Mayaleeeee
Copy link
Member

@Mayaleeeee do I need to update this branch with the master branch?

Yeah, I guess so.
cc @AceTheCreator

@AceTheCreator
Copy link
Member

@MahendraDani did you remove the old twitter logo?

@MahendraDani
Copy link
Contributor Author

MahendraDani commented Nov 22, 2023

@AceTheCreator I have removed the old twitter logo and used the new one. But I have not deleted the public/img/Twitter.png which is the old twitter logo.
Should I delete public/img/Twitter.png from the repo?

@AceTheCreator
Copy link
Member

@AceTheCreator I have removed the old twitter logo and used the new one. But I have not deleted the public/img/Twitter.png which is the old twitter logo. Should I delete public/img/Twitter.png from the repo?

Yes, please delete it

@MahendraDani
Copy link
Contributor Author

@AceTheCreator
Deleted old tweeter logo from repo in 47e882f

@AceTheCreator
Copy link
Member

LGTM!!! Well done @MahendraDani

@AceTheCreator AceTheCreator merged commit 84c9b07 into asyncapi:master Nov 23, 2023
11 checks passed
@MahendraDani
Copy link
Contributor Author

MahendraDani commented Nov 23, 2023

@AceTheCreator Thanks for merging the PR.
If there are any issues that I can help with please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update twitter icon and add interactions
3 participants