-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report on each completed voting the TSC participation #1268
Comments
Seems nice idea @derberg what should be the next step ? Do we need to higlight the names of the people. |
Hi @AayushSaini101, since you are not a TSC Member, you cannot start or stop voting. Please read more about voting process |
@AayushSaini101 look at bot message, something wrong with automation. sorry, I didn't get your question, can you rephrase? |
@derberg sorry actually by mistake i added vote string in the comment that cause the above bot message, then i edited the message. Do we just only print the name of the TSC members and send a notification to the members ? |
but there is nothing about sending notification to TSC members in scope of this issue. It is purely only about creating a voting report |
Thanks @derberg I am willing to work on this issue. If it is okay for you. can we submit it for bounty program Q3 ? |
submitted you can already explore and suggest solution we have a list of maintainers and tsc members already as YAML format, maybe better to extend it with voting info, so each TSC member has a collection of votes? Then basing on the data from YAML, a markdown summary can be generated |
Sure @derberg I will give update on this |
@derberg Here is the the solution step
When the member give voting in the process
When the member doesn't participate in voting in 3 Months: { |
The POC for the solution:
|
Hi @AayushSaini101, since you are not a TSC Member, you cannot start or stop voting. Please read more about voting process |
We, Need to change this
|
Hi @AayushSaini101, since you are not a TSC Member, you cannot start or stop voting. Please read more about voting process |
Bounty Issue's service commentText labels: @asyncapi/bounty_team The Bounty Program is not a Mentorship Program. The accepted level of Bounty Program Participants is Middle/Senior.Third-party contributors should coherently articulate how they are going to approach the resolution process when expressing a desire to work on this Bounty Issue. |
@derberg can you please assign me the issue ? |
@AayushSaini101 done |
I noticed I forgot that I was suppose to wait 3 days before I publish a decision who will work on issues. I don't have a better excuse other than "Monday". My apologies. |
Bounty Issue's Timeline
Please note that the dates given represent deadlines, not specific dates, so if the goal is reached sooner, it's better.Keep in mind the responsibility for violations of the Timeline. |
please have a look on requirements
so we need a full summary:
please try to first manually create some table, don't waste time on code and json. Rather do a dummy manual google sheet with names and vote topics and how such info could be in the end rendered as a table. Once we get this, then you can do code and json don't rush, we are not in a competition |
@derberg Thanks for the suggetions : ) We can follow the structure of the table to store voting details of TSC Members. Structure 1:
Structure 2: If we want to store the history of voting details for 3 Months
Let me know your thoughts on the structure @derberg thanks :) |
you did really great suggestions that let me craft below summary
wdyt? |
Answer: We can introduce another column that is lastClosedVoteTime for every member that track the voting history status of every member, i have already done in the current PR For the case of irregular vote: we can maintain a global value for last voting time, and from this we can verify whether we need to update the hasVotedInLast3Months or not: Updated Structure:
This will be the format we can store in json, |
maybe nothing special is needed 🤔 cause in the end, counting workflow is set to react only on closed vote. This means calculation of last 3 months will happen only based on last voting. So really even if there will be no voting for 3 months - nothing bad will happen 🤔 |
all is covered here once #1313 vote is closed we will see this new workflow in action. From the initial data we have, I'm confident all will work fine |
Bounty Issue Is Completed 🎉@AayushSaini101, please go to the AsyncAPI page on Open Collective and submit an invoice for |
Before we start notifying people with automated way like #1194 let's first actually get transparent data and basing on data I can "manually" approach people first.
so we have git-vote that does automated voting for us. We can easily extract a list of "voting" issues and PRs and parse them for information.
we need:
gitvote
label gets a comment fromgit-vote
sayingVote closed
first propose a structure of info, with current available data you can mock it without coming up with dummy data
The text was updated successfully, but these errors were encountered: