-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add watch
option
#73
Comments
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
A question @derberg |
best would be if it is global but that you need to enable it for given command 😄 so validate, diff, should have it, but new, start not really. So would be awesome to have it generic in a sense that when we add new generate command, we easily enable watch for it |
we already do some watching here Line 17 in 058114c
so it is a matter of making a global function that can be reused by a command that needs it |
That means the flow goes like this 👇
Correct me, if somewhere missing any point |
@derberg The watcher PR is ready to review: #220 I got a bit in stuck moment when writing test for
Need some solutions on how do we approach it? Mocking Streams or any other way ? |
tbh I'm not sure, I would first try to check if chokidar community figured it out already, maybe something is already in their issues, or you can check others that use chokidar and how they solved testing. I would go first this direction to see how others tacked it |
@imabp well done 👏🏼 |
Reason/Context
We need native way for watching AsyncAPI resource and reiterate given command on it. So basically
asyncapi validate -w
works in a way that whenever users introduce change in a file, validation runs on it again without invoking it.sure user can now just install watcher like
brew install watch
and dowatch asyncapi validate
, but this should be considered as a temporary workaround that is not a good UX.Description
When working on this functionality we need to look on current functionality on Generator CLI and its current issues, to fix them here in the CLI -> asyncapi/generator#537 (comment)
The text was updated successfully, but these errors were encountered: