Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do something with automated brew formula update #503

Closed
derberg opened this issue Apr 3, 2023 · 5 comments · Fixed by #532
Closed

Do something with automated brew formula update #503

derberg opened this issue Apr 3, 2023 · 5 comments · Fixed by #532
Labels
enhancement New feature or request released

Comments

@derberg
Copy link
Member

derberg commented Apr 3, 2023

Context

whenever we release here, bot also creates PR to brew to update formula -> https://github.com/asyncapi/cli/blob/master/.github/workflows/bump-homebrew-formula.yml

because sometimes we have days when we merge a lot of PRs, we become harmful and spammers to brew folks -> Homebrew/homebrew-core#127077

Solution

I was thinking that maybe we should just change from push event to cron and it will be ok if we run update of brew formula:

  • once a day, end of the day
  • and PR is opened on brew when there are changes, of course not every day

IMPORTANT

Before we fix this problem, @Souvikns @magicmatatjahu @boyney123 let us make sure we do not merge more than one feat or fix a day 🙏🏼

Thoughts ?

@derberg derberg added the enhancement New feature or request label Apr 3, 2023
@achiverram28
Copy link

Could I help you guys in contributing to this

@derberg
Copy link
Member Author

derberg commented Apr 4, 2023

@achiverram28 definitely, but please give other maintainers few days to share opinion. If there is silent approval or not-silent YES for the cron approach, you can definitely submit PR to update the GitHub worflow

@derberg
Copy link
Member Author

derberg commented Apr 6, 2023

@achiverram28 go ahead and update the workflow to make sure it still works but on cron event trigger.

@achiverram28
Copy link

Yup , on it

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 0.39.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants