-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do something with automated brew formula update #503
Comments
Could I help you guys in contributing to this |
@achiverram28 definitely, but please give other maintainers few days to share opinion. If there is silent approval or not-silent YES for the cron approach, you can definitely submit PR to update the GitHub worflow |
@achiverram28 go ahead and update the workflow to make sure it still works but on |
Yup , on it |
🎉 This issue has been resolved in version 0.39.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Context
whenever we release here, bot also creates PR to brew to update formula -> https://github.com/asyncapi/cli/blob/master/.github/workflows/bump-homebrew-formula.yml
because sometimes we have days when we merge a lot of PRs, we become harmful and spammers to
brew
folks -> Homebrew/homebrew-core#127077Solution
I was thinking that maybe we should just change from
push
event tocron
and it will be ok if we run update of brew formula:brew
when there are changes, of course not every dayIMPORTANT
Before we fix this problem, @Souvikns @magicmatatjahu @boyney123 let us make sure we do not merge more than one
feat
orfix
a day 🙏🏼Thoughts ?
The text was updated successfully, but these errors were encountered: