Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove @asyncapi/parser from dependencies #89

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

Souvikns
Copy link
Member

Description

Removing https://github.com/asyncapi/parser-js from dependencies We have currently stopped parsing and validating specifications in bundler, we expect the spec that we get as a parameter to already be parsed and validated.

Related issue(s)

Fixes #26

@derberg
Copy link
Member

derberg commented Oct 27, 2022

@Souvikns I'm wondering if we should write something about it in Readme 🤔 but I don't think so 🤔

@aeworxet wanna have a look before we merge?

@aeworxet aeworxet changed the title feat: remove @asyncapi/parser from dependencies fix: remove @asyncapi/parser from dependencies Oct 31, 2022
@aeworxet
Copy link
Collaborator

Changed subject of PR to fix: as dependencies are removed.

@aeworxet
Copy link
Collaborator

LGTM

@aeworxet aeworxet self-requested a review as a code owner October 31, 2022 14:43
@aeworxet
Copy link
Collaborator

/rtm

@asyncapi-bot asyncapi-bot merged commit b5d3d53 into asyncapi:master Oct 31, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.3.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove usage of Parser, validation and update docs
4 participants