Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add resolution of $refs in subdirectories #181

Conversation

aeworxet
Copy link
Collaborator

@aeworxet aeworxet commented Aug 6, 2024

This PR:

  • Adds resolution of $refs in subdirectories.

  • Refactors the application's code, getting the codebase ready for future implementations.

Resolves #178

@Laupetin
Copy link

Laupetin commented Aug 6, 2024

Tested it on my example and it works fine. The problem I had should be solved with that, thanks :)

Souvikns
Souvikns previously approved these changes Aug 6, 2024
Copy link
Member

@Souvikns Souvikns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@aeworxet aeworxet marked this pull request as ready for review August 6, 2024 19:44
Copy link

sonarqubecloud bot commented Aug 7, 2024

@aeworxet
Copy link
Collaborator Author

aeworxet commented Aug 7, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit e41d6e4 into asyncapi:master Aug 7, 2024
10 checks passed
@aeworxet aeworxet deleted the feat-add-resolution-of-refs-in-subdirectories branch August 7, 2024 07:31
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Resolve $refs relative to the parsed file's directory by default
4 participants