-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support to display examples #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
Kudos, SonarCloud Quality Gate passed! |
@ITman1 fyi, I asked the community to share their opinion on a related issue as I'm not sure if we should actually provide such a support |
@derberg That is good question, main problem I see that it is not standardized anywhere, but AFAIK Avro Schema does not disalow to define those attributes. |
This pull request has been automatically marked as stale because it has not had recent activity 😴 |
@ITman1 please update with latest master |
@derberg Updated from upstream repo |
When will this be merged? I would like to use this ASAP in my project. |
@ITman1 please have a look at failing linter, it complains on the complexity of the code |
@derberg Tried to extract some code into seperate functions, Sonar does not complain anymore locally. Both tests started to fail after my change so I also adjusted expected test results. IMHO there was a bug, Avro can have 'null' as default values, before null was ignored from the spec files and so does also 0 I would guess. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one tiny request to add one additional comment to the code + please update readme with information of extra fields support
From my side, it could be nice to have this feature merged. Here is the result of my generation based on |
Kudos, SonarCloud Quality Gate passed! |
🎉 This PR is included in version 0.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
example
attribute is specified alongside with type/record field definition it is propagated intoexamples
attribute of AsyncAPI schemaRelated issue(s)
Implements
example
feature from #18