Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avro type float (also double ?) is converted to number but without float label displayed #14

Closed
M3lkior opened this issue Oct 7, 2020 · 8 comments

Comments

@M3lkior
Copy link
Collaborator

M3lkior commented Oct 7, 2020

Describe the bug

When using a float type (maybe also with double type) in Avro schema, the rendering HTML template don't display the float label near the number type

Given this field :

        {"name": "SUPPLIER_PRICE", "type": "float", "doc": "The article price (purchasing price)."},

Here is the HTML rendering :

image

But we expect to have this HTML rendering :

image

How to Reproduce

Steps to reproduce the issue. Attach all resources that can help us understand the issue:
Here is the related gist : https://gist.github.com/M3lkior/e282c8ebd3ac94759d4f58ebefdb8f49

Expected behavior

The float label must appears in HTML template generation :

image

@M3lkior M3lkior added the bug Something isn't working label Oct 7, 2020
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions github-actions bot added the stale label Dec 12, 2020
@derberg derberg removed bug Something isn't working stale labels Dec 14, 2020
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions github-actions bot added the stale label Feb 13, 2021
@derberg derberg removed the stale label Feb 15, 2021
@M3lkior
Copy link
Collaborator Author

M3lkior commented Mar 15, 2021

For Logical type, the parser should use the logicalType attribute : https://avro.apache.org/docs/current/spec.html#Logical+Types

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions github-actions bot added the stale label May 15, 2021
@derberg derberg removed the stale label May 17, 2021
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions github-actions bot added the stale label Jul 17, 2021
@derberg
Copy link
Member

derberg commented Jul 26, 2021

Avro parser transforms Avro to JSON Schema. Where in the JSON Schema would you put such additional info?

@derberg derberg removed the stale label Aug 23, 2021
@M3lkior
Copy link
Collaborator Author

M3lkior commented Oct 22, 2021

this limitation is solved in the pr #82

@M3lkior
Copy link
Collaborator Author

M3lkior commented Oct 27, 2021

@M3lkior M3lkior closed this as completed Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants