Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable preflight (css normalizer) from TailwindCSS #368

Closed
magicmatatjahu opened this issue Jun 15, 2021 · 2 comments
Closed

Disable preflight (css normalizer) from TailwindCSS #368

magicmatatjahu opened this issue Jun 15, 2021 · 2 comments
Labels
area/library Related to all activities around Library package bug Something isn't working
Milestone

Comments

@magicmatatjahu
Copy link
Member

magicmatatjahu commented Jun 15, 2021

Description

Regarding to this comment #177 (comment):

Default stylesheet looks more like a page one than a component one, with a lot of resets, defaults, etc. It had some minor side effects over other styles in my page, but nothing critical. I guess this is related with the new tailwind-based styles and will be improved in the future.

we should disable the default css normalizer (css reset) from final styles produced by TailwindCSS. We can use the https://tailwindcss.com/docs/preflight#disabling-preflight option, but...

we have some issue related to the disabling: we should have saved in another file the reset css, because in most cases people need the reset in their application, for example, our html-template should import the preflight. In the rest it should be optional, because people probably have imported normalizer from other sources and we cannot "break" their styles.

So we should produce two css:

  • with reset
  • without reset - with name {name of theme}.reset.min.css
@github-actions
Copy link

github-actions bot commented Sep 6, 2021

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

@magicmatatjahu
Copy link
Member Author

Fixed by #493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/library Related to all activities around Library package bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant