Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite components to stateless components and use React hooks #36

Closed
magicmatatjahu opened this issue Feb 2, 2019 · 23 comments
Closed

Rewrite components to stateless components and use React hooks #36

magicmatatjahu opened this issue Feb 2, 2019 · 23 comments
Labels
area/library Related to all activities around Library package area/playground Related to all activities around Playground app enhancement New feature or request stale

Comments

@magicmatatjahu
Copy link
Member

Description

At the moment library and playground app have in the vast majority stateful components (created by class). In 16.8.0 version of React, the hooks feature will be made available.

AC:

  • rewrite components to stateless components,
  • if component has a state, please add state functionality by using React hooks.

Reasons

Willingness to improve speed of rendering and more readable code.

Attachements
@magicmatatjahu magicmatatjahu added enhancement New feature or request area/library Related to all activities around Library package area/playground Related to all activities around Playground app labels Feb 2, 2019
@magicmatatjahu magicmatatjahu changed the title Rewrite components to stateless components by using React hooks Rewrite components to stateless components and use React hooks Feb 2, 2019
@derberg
Copy link
Member

derberg commented Feb 7, 2019

@all-contributors please add magicmatatjahu for code, doc, ideas, maintenance,

@allcontributors allcontributors bot mentioned this issue Feb 7, 2019
Merged
@allcontributors
Copy link
Contributor

@derberg

I've put up a pull request to add @magicmatatjahu! 🎉

@derberg derberg mentioned this issue Feb 7, 2019
Closed
@derberg
Copy link
Member

derberg commented Feb 7, 2019

@all-contributors please add kazydek for doc, review, maintenance, please add akucharska for code, maintenance and please add derberg for doc, examples, ideas

@allcontributors
Copy link
Contributor

@derberg

I could not determine your intention.

Basic usage: @all-contributors please add @jakebolam for code, doc and infra

For other usages see the documentation

@derberg
Copy link
Member

derberg commented Feb 7, 2019

@all-contributors please add kazydek for doc, review, maintenance

@allcontributors allcontributors bot mentioned this issue Feb 7, 2019
Merged
@allcontributors
Copy link
Contributor

@derberg

I've put up a pull request to add @kazydek! 🎉

@derberg
Copy link
Member

derberg commented Feb 7, 2019

@all-contributors please add akucharska for code, maintenance

@allcontributors allcontributors bot mentioned this issue Feb 7, 2019
Closed
@allcontributors
Copy link
Contributor

@derberg

I've put up a pull request to add @akucharska! 🎉

@derberg
Copy link
Member

derberg commented Feb 7, 2019

@all-contributors please add derberg for doc, examples, ideas

@allcontributors allcontributors bot mentioned this issue Feb 7, 2019
Closed
@allcontributors
Copy link
Contributor

@derberg

I've put up a pull request to add @derberg! 🎉

@derberg
Copy link
Member

derberg commented Feb 8, 2019

@all-contributors please add akucharska for code, maintenance

@allcontributors allcontributors bot mentioned this issue Feb 8, 2019
Closed
@allcontributors
Copy link
Contributor

@derberg

I've put up a pull request to add @akucharska! 🎉

@derberg
Copy link
Member

derberg commented Feb 8, 2019

@all-contributors please add akucharska for code, maintenance

@allcontributors allcontributors bot mentioned this issue Feb 8, 2019
Merged
@allcontributors
Copy link
Contributor

@derberg

I've put up a pull request to add @akucharska! 🎉

@derberg
Copy link
Member

derberg commented Feb 8, 2019

@all-contributors please add derberg for doc, examples, ideas

@allcontributors allcontributors bot mentioned this issue Feb 8, 2019
Merged
@allcontributors
Copy link
Contributor

@derberg

I've put up a pull request to add @derberg! 🎉

@derberg
Copy link
Member

derberg commented Feb 8, 2019

sorry for spamming the issue :(

@jakebolam
Copy link

Multi user add coming soon! all-contributors/app#100

@aerfio
Copy link
Contributor

aerfio commented Sep 5, 2019

@all-contributors please add aerfio for code, doc, ideas, maintenance, review, tests

@allcontributors allcontributors bot mentioned this issue Sep 5, 2019
Merged
@allcontributors
Copy link
Contributor

@aerfio

I've put up a pull request to add @aerfio! 🎉

@magicmatatjahu
Copy link
Member Author

@all-contributors please add magicmatatjahu for code, doc, ideas, maintenance, review, tests

@allcontributors allcontributors bot mentioned this issue Sep 10, 2019
Merged
@allcontributors
Copy link
Contributor

@magicmatatjahu

I've put up a pull request to add @magicmatatjahu! 🎉

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 30 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions github-actions bot added the stale label Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/library Related to all activities around Library package area/playground Related to all activities around Playground app enhancement New feature or request stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jakebolam @derberg @aerfio @magicmatatjahu