Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect Netlify to our repository #306

Closed
magicmatatjahu opened this issue Apr 20, 2021 · 8 comments
Closed

Connect Netlify to our repository #306

magicmatatjahu opened this issue Apr 20, 2021 · 8 comments
Labels
area/community Related to all activities that are done for community area/playground Related to all activities around Playground app enhancement New feature or request

Comments

@magicmatatjahu
Copy link
Member

Description

At the moment we host our playground in the Github Pages. If we go with Netlify hosting we can test and see changes from PR from Netlify temporary site for PR. I don't know if there is a possibility to connect this repo to Netlify account used by website. Someone must check it.

Reasons

To Improve DX in PR's review.

@magicmatatjahu magicmatatjahu added enhancement New feature or request area/playground Related to all activities around Playground app area/community Related to all activities that are done for community labels Apr 20, 2021
@magicmatatjahu magicmatatjahu changed the title Connect netlify to our repository Connect Netlify to our repository Apr 20, 2021
@aayushmau5
Copy link
Member

I will check if it can be done.

@aayushmau5
Copy link
Member

aayushmau5 commented Apr 20, 2021

Just checked. Yeah, Netlify supports deploying multiple repos from the same account.

@magicmatatjahu
Copy link
Member Author

@aayushmau5 Thanks for checking it! :)

@fmvilas
Copy link
Member

fmvilas commented Apr 20, 2021

Do we want to keep this playground? I mean, we already have AsyncAPI Studio. I'd focus all efforts in this direction.

@magicmatatjahu
Copy link
Member Author

magicmatatjahu commented Apr 20, 2021

@fmvilas Right, but we have requests to publish to npm playground (or only editor part like in Studio) in this issue and here. We can copy this editor from studio (which is better, because under the hood we use monaco-editor, not codemirror) and have @asyncapi/editor which will be used in studio and as standalone. What do you think? Of course code for this editor will be where currently is playground in this repo.

Swagger has also editor published as standalone component https://github.com/swagger-api/swagger-editor and for me this is a good approach.

Netlify here will be only used to test from PR changes :)

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

@magicmatatjahu
Copy link
Member Author

It's not necessary at this time. If there is a need, I will open issue again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/community Related to all activities that are done for community area/playground Related to all activities around Playground app enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants