add record checking for allennlp and spacy #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunterhector
reviewed
Apr 5, 2021
| the pipeline. | ||
| """ | ||
| expectation_dict: Dict[str, Set[str]] = dict() | ||
| expectation_dict["ft.onto.base_ontology.Sentence"] = set() |
There was a problem hiding this comment.
As a demonstration, probably we can make this function simpler by using the literal implementation:
Suggested change
| expectation_dict["ft.onto.base_ontology.Sentence"] = set() | |
| expectation_dict: Dict[str, Set[str]] = { | |
| "ft.onto.base_ontology.Sentence": set() | |
| } |
hunterhector
reviewed
Apr 6, 2021
| if "pos" in self.configs.processors: | ||
| record_meta["ft.onto.base_ontology.Token"].add("pos") | ||
| if "depparse" in self.configs.processors: | ||
| record_meta["ft.onto.base_ontology.Dependency"] = set() |
Merged
hunterhector
reviewed
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #6.
Description of changes
Added record writing for
SpaCyprocessor to note the output contains theSentencetype which is required by other processors for exampleAllenNlpprocessor. Added record checking forAllenNlpprocessor which means it requiresSentencetype in the input datapack. The record checking could be enabled withpipeline.enforce_consistency(enforce=True).Possible influences of this PR.
None
Test Conducted
Not yet.