Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Test identifier functions #405

Open
hamogu opened this issue Nov 27, 2018 · 0 comments
Open

Testing: Test identifier functions #405

hamogu opened this issue Nov 27, 2018 · 0 comments
Labels

Comments

@hamogu
Copy link
Member

hamogu commented Nov 27, 2018

Most test in https://github.com/astropy/specutils/blob/master/specutils/tests/test_loaders.py actively set the loader, e.g.:

spec = Spectrum1D.read(tmp_file.name, format="SDSS-III/IV spec")

All these tests should be parameterized to be run twice: With and without the format keyword to make sure that the identifier functions work. (This is very analogous to the astropy.io.ascii tests and experience there shows really both tests are needed.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants