Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

astropy v7.0 incompatibility in TestMasksTracing.test_fit_trace_all_nan_cols #229

Open
pllim opened this issue Nov 11, 2024 · 3 comments · May be fixed by #232
Open

astropy v7.0 incompatibility in TestMasksTracing.test_fit_trace_all_nan_cols #229

pllim opened this issue Nov 11, 2024 · 3 comments · May be fixed by #232
Labels
bug

Comments

@pllim
Copy link
Member

pllim commented Nov 11, 2024

According to astropy-integration-testing run, there is failure with both stable and dev versions, so this package needs a compatibility fix and a new release to be compatible with astropy v7.0.0. FYI.
@pllim
Copy link
Member Author

pllim commented Nov 11, 2024

And looks like you been warned of this for a long time in your cron jobs but it was left unhandled.

@pllim pllim added the bug label Nov 11, 2024
@pllim
Copy link
Member Author

pllim commented Nov 11, 2024 

>       np.testing.assert_allclose(truth, max_trace.trace)
E       AssertionError: 
E       Not equal to tolerance rtol=1e-07, atol=0
E       
E       Mismatched elements: 11 / 11 (100%)
E       Max absolute difference among violations: 0.00700257
E       Max relative difference among violations: 0.00360873
E        ACTUAL: array([1.947455, 2.383634, 2.819813, 3.255992, 3.692171, 4.12835 ,
E              4.564529, 5.000708, 5.436887, 5.873067, 6.309246])
E        DESIRED: MaskedArray([1.940452, 2.376862, 2.813273, 3.249683, 3.686093, 4.122503,
E                    4.558913, 4.995323, 5.431733, 5.868143, 6.304553])

This test already ignores a bunch of warnings, so maybe not a well designed test to begin with. Just increase the tolerance?

Also appears to be using a fitter that is no longer recommended, see:

hpparvi added a commit to hpparvi/specreduce that referenced this issue Nov 15, 2024
@hpparvi
Fixed Issue astropy#229: increased the absolute and relative toleranc…
8905657 
…es of 'assert_allclose'.
@hpparvi hpparvi linked a pull request Nov 15, 2024 that will close this issue
Open
@hpparvi
Copy link
Contributor

hpparvi commented Nov 15, 2024

This should be fixed now in PR #232.

hpparvi added a commit to hpparvi/specreduce that referenced this issue Nov 15, 2024
@hpparvi
Fixed Issue astropy#229: increased the absolute and relative toleranc…
97add95 
…es of 'assert_allclose'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for Astropy v7.0 incompatibility (#229) hpparvi/specreduce
2 participants
@hpparvi @pllim