Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: warning from registry example #359

Open
bsipocz opened this issue Sep 20, 2022 · 2 comments
Open

DOC: warning from registry example #359

bsipocz opened this issue Sep 20, 2022 · 2 comments

Comments

@bsipocz
Copy link
Member

bsipocz commented Sep 20, 2022

The example we show in the documentation issues a W02 warning. Is there anything we can do about it? It's not like the users can, so it should either be captured in the library code itself, or the example reworked so it's not being issued to begin with

cc @msdemlei

Code:

from pyvo import registry
resources = registry.search(registry.UCD("src.redshift"), registry.Freetext("supernova"))
resources[4].get_tables()

warning:

/Users/bsipocz/munka/devel/pyvo/pyvo/io/vosi/vodataservice.py:836: W02: ?:?:?: W02: '' is not a valid datatype according to the VOSI spec
  vo_warn(W02, value, self._config, self._pos)
Out[4]: {'J/A+A/437/789/table2': <Table name="J/A+A/437/789/table2">... 19 columns ...</Table>}
@bsipocz
Copy link
Member Author

bsipocz commented Sep 20, 2022

OK, so this one actually came up in the PR review, and is something upstream:

#289 (comment)

I'll add the ignore warnings for the doctests, yet would encourage to think about using an example that doesn't throw the warning.

@msdemlei
Copy link
Contributor

msdemlei commented Sep 21, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants