First tutorial in specutils series #491
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trying to bring my material up-to-date with astropy-tutorials main
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
kelle
reviewed
Jul 29, 2021
| @@ -0,0 +1,475 @@ | |||
| { | |||
There was a problem hiding this comment.
What's the motivation for calling it xid. Is there a more descriptive variable name we could use?
Reply via ReviewNB
There was a problem hiding this comment.
How about crossmatch_id ?
eblur
commented
Jul 22, 2022
eblur
commented
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of a specutils tutorial series
How to Load, Plot, and Smooth an Optical Spectrum from SDSS
Ready for review. This is in response to Issue #440