Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Task timeout and SLA support #1316

Open
1 task done
t0momi219 opened this issue Nov 12, 2024 · 1 comment · May be fixed by #1317
Open
1 task done

[Feature] Task timeout and SLA support #1316

t0momi219 opened this issue Nov 12, 2024 · 1 comment · May be fixed by #1317
Labels
area:rendering Related to rendering, like Jinja, Airflow tasks, etc enhancement New feature or request triage-needed Items need to be reviewed / assigned to milestone

Comments

@t0momi219
Copy link
Contributor

Description

In Airflow, both DAGs and tasks can have timeout and SLA times specified. Since dbt models likely have varying expected execution times for each layer, there could be cases where users want to apply SLAs individually to each node.

How about having Cosmos retrieve timeout and SLA times from the node metadata and apply them individually when rendering nodes?

Use case/motivation

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes, I am willing to submit a PR!
@t0momi219 t0momi219 added enhancement New feature or request triage-needed Items need to be reviewed / assigned to milestone labels Nov 12, 2024
@t0momi219 t0momi219 linked a pull request Nov 12, 2024 that will close this issue
Open
2 tasks
@dosubot dosubot bot added the area:rendering Related to rendering, like Jinja, Airflow tasks, etc label Nov 12, 2024
@pankajkoti
Copy link
Contributor

hi @t0momi219 . Sounds like a great idea. I am definitely up for the idea of timeouts. When it comes to SLA, I'm hearing that they might take away the concept of SLAs in Airflow 3 and come up with something better in later releases of AF 3. So, if you're willing, definitely would encourage the contribution for supporting timeout from node metadata and applying it to AF tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:rendering Related to rendering, like Jinja, Airflow tasks, etc enhancement New feature or request triage-needed Items need to be reviewed / assigned to milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add task sla and timeout support. t0momi219/astronomer-cosmos
2 participants
@pankajkoti @t0momi219