From 8885fc1d9516b30b316487f21e37d34bdd21e40e Mon Sep 17 00:00:00 2001
From: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Date: Tue, 6 Jul 2021 12:37:31 -0600
Subject: [PATCH] Chart: warn when using default logging with
 KubernetesExecutor (#16784)

---
 chart/templates/NOTES.txt | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/chart/templates/NOTES.txt b/chart/templates/NOTES.txt
index 49ad09719f12c..454088f43e95e 100644
--- a/chart/templates/NOTES.txt
+++ b/chart/templates/NOTES.txt
@@ -66,6 +66,17 @@ You can get Fernet Key value by running the following:
 
 {{- end }}
 
+{{- if or (eq .Values.executor "KubernetesExecutor") (eq .Values.executor "CeleryKubernetesExecutor") }}
+{{- if and (not .Values.logs.persistence.enabled) (eq (lower (tpl .Values.config.logging.remote_logging .)) "false") }}
+
+WARNING:
+    Kubernetes workers task logs may not persist unless you configure log persistence or remote logging!
+    Logging options can be found at: https://airflow.apache.org/docs/helm-chart/stable/manage-logs.html
+    (This warning can be ignored if logging is configured with environment variables or secrets backend)
+
+{{- end }}
+{{- end }}
+
 {{- if and .Values.dags.gitSync.enabled .Values.dags.gitSync.sshKeySecret (not .Values.dags.gitSync.knownHosts)}}
 
 #####################################################