Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClockifyClient.FindAllTimeEntriesForProjectAsync "hydrated" parameter makes no sense #62

Open
topennanen opened this issue May 2, 2022 · 6 comments
Milestone

Comments

@topennanen
Copy link

As the method can only return unhydrated time entries (TimeEntryDtoImpl) , the parameter "hydrated" is useless.

Suggestion: Separate method for hydrated time entries, which uses appropriate method for the use time entry queries (ClockifyClient.FindAllHydratedTimeEntriesForUserAsync) and returns HydratedTimeEntryDtoImpl

@Morasiu
Copy link
Collaborator

Morasiu commented May 3, 2022

I will check it with current API. Thanks for suggestion!

@Morasiu
Copy link
Collaborator

Morasiu commented May 7, 2022

I see I already have FindAllHydratedTimeEntriesForUserAsync. Is it enough for your needs?

@topennanen
Copy link
Author

Not really, no. The use case is finding all time entries for a task, regardless of the user, along with the names of the users who made those entries.

@Morasiu
Copy link
Collaborator

Morasiu commented May 10, 2022

So a method like FindAllHydratedTimeEntriesForUserAsync, but FindAllHydratedTimeEntriesForTaskAsync?

@topennanen
Copy link
Author

That, or FindAllHydratedTimeEntriesForProjectAsync for a wider usage in line with the current non-hydrated method.

@Morasiu
Copy link
Collaborator

Morasiu commented May 10, 2022

Roger that, will do :)

@Psypher9 Psypher9 added this to the 3.0.0 milestone Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants