Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use larger runners for bottleneck builds of release artifacts #9239

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Nov 19, 2024

Uses a different runner for builds that take >15m.

Most of the builds finish in ~10 minutes.

@zanieb zanieb added the internal A refactor or improvement that is not user-facing label Nov 19, 2024
@zanieb zanieb marked this pull request as ready for review November 19, 2024 19:59
@zanieb
Copy link
Member Author

zanieb commented Nov 19, 2024

The Windows jobs still look like a bottleneck, but I'm not sure I want to switch to the extra large runners.

@charliermarsh
Copy link
Member

Should we use smaller runners for the fast builds or something? Probably a bad idea.

@zanieb
Copy link
Member Author

zanieb commented Nov 19, 2024

I don't think we can, we're using the GitHub defaults which are small and free.

If anything, I'd want to use the fast runners for everything and get the release time down so we don't need to monitor it as long — it's not worth the investment right now though.

@zanieb zanieb merged commit 6eeb515 into main Nov 19, 2024
82 checks passed
@zanieb zanieb deleted the zb/release-runner branch November 19, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal A refactor or improvement that is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants