Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving toga-gtk attempts to build pygobject on MacOS #9548

Closed
ncoghlan opened this issue Dec 1, 2024 · 0 comments · Fixed by #9549
Closed

Resolving toga-gtk attempts to build pygobject on MacOS #9548

ncoghlan opened this issue Dec 1, 2024 · 0 comments · Fixed by #9549
Labels
enhancement New feature or improvement to existing functionality

Comments

@ncoghlan
Copy link

ncoghlan commented Dec 1, 2024

toga-gtk fails to generate a valid cross-platform lock file when added as a dependency on platforms other than Linux, as pygobject can only be published as an sdist: beeware/toga#2995

(statically linking the GObject bindings is not desirable, and a valid manylinux wheel can't just assume those libraries exist)

Setting tool.uv.dependency.metadata doesn't solve the problem, since that's only effective for application locks - the tool table metadata doesn't make it into the toga-gtk .dist-info folder, so uv add doesn't have access to it when the dependency on toga-gtk is resolved.

Searching the code for build_wheel and prepare_metadata_for_build_wheel, it isn't clear to me if the problem is that uv simply isn't trying the latter option before progressing to the full wheel build, or if the latter isn't working with meson-build, so uv is falling back to the former, which than fails due to the platform incompatibility.

Potentially related:

@ncoghlan ncoghlan changed the title uv attempts to build pygobject on MacOS when resolving toga-gtk dependencies uv attempts to build pygobject on MacOS when resolving toga-gtk Dec 1, 2024
@ncoghlan ncoghlan changed the title uv attempts to build pygobject on MacOS when resolving toga-gtk Resolving toga-gtk attempts to build pygobject on MacOS Dec 1, 2024
@konstin konstin added the enhancement New feature or improvement to existing functionality label Dec 4, 2024
@konstin konstin closed this as completed in c314c68 Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement to existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants