Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uv python install does not respect rc qualifiers #7977

Closed
gaborbernat opened this issue Oct 7, 2024 · 3 comments · Fixed by #8020
Closed

uv python install does not respect rc qualifiers #7977

gaborbernat opened this issue Oct 7, 2024 · 3 comments · Fixed by #8020
Assignees
Labels
bug Something isn't working good first issue Good for newcomers uv python Related to the uv python interface

Comments

@gaborbernat
Copy link
Contributor

gaborbernat commented Oct 7, 2024

It installs rc2 even though I request rc3... 😊

❯ uv python install 3.13.0rc3 --native-tls -vv
    0.000272s DEBUG uv uv 0.4.17
    0.000755s DEBUG uv_fs Acquired lock for `/Users/bgabor8/Library/Application Support/uv/python`
Searching for Python versions matching: Python 3.13rc3
    0.001142s DEBUG uv_client::base_client Using request timeout of 30s
 uv_python::downloads::fetch self=ManagedPythonDownload { key: PythonInstallationKey { implementation: Known(CPython), major: 3, minor: 13, patch: 0, prerelease: "rc2", os: Os(Darwin), arch: Arch(Aarch64(Aarch64)), libc: None }, url: "https://github.com/indygreg/python-build-standalone/releases/download/20240909/cpython-3.13.0rc2%2B20240909-aarch64-apple-darwin-install_only_stripped.tar.gz", sha256: Some("9e17f9fcc314a5dd489089a7502a525c4dd08af862f9cf33b52161a752f2a5b7") }, download=cpython-3.13.0rc2-macos-aarch64-none
   11.971556s  11s  DEBUG uv_python::downloads Downloading https://github.com/indygreg/python-build-standalone/releases/download/20240909/cpython-3.13.0rc2%2B20240909-aarch64-apple-darwin-install_only_stripped.tar.gz to temporary location: /Users/bgabor8/Library/Application Support/uv/python/.cache/.tmphDfaX1
   11.971687s  11s  DEBUG uv_python::downloads Extracting cpython-3.13.0rc2%2B20240909-aarch64-apple-darwin-install_only_stripped.tar.gz
   12.968445s  12s  DEBUG uv_python::downloads Moving /Users/bgabor8/Library/Application Support/uv/python/.cache/.tmphDfaX1/python to /Users/bgabor8/Library/Application Support/uv/python/cpython-3.13.0rc2-macos-aarch64-none
Installed Python 3.13.0rc2 in 12.96s
 + cpython-3.13.0rc2-macos-aarch64-none
   12.969182s DEBUG uv_fs Released lock at `/Users/x/Library/Application Support/uv/python/.lock`
❯ uv --version
uv 0.4.17 (d2e7b40ce 2024-09-27)
@zanieb
Copy link
Member

zanieb commented Oct 7, 2024

We're missing a check for pre-release compatibility at

if !version.matches_major_minor_patch(key.major, key.minor, key.patch) {
return false;
}

@zanieb zanieb added bug Something isn't working good first issue Good for newcomers uv python Related to the uv python interface labels Oct 7, 2024
@trag1c
Copy link
Contributor

trag1c commented Oct 7, 2024

I'd like to give this a go :) Can I get assigned to this issue?

@konstin
Copy link
Member

konstin commented Oct 7, 2024

I assigned you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers uv python Related to the uv python interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants