Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deadlock during resolution #3724

Closed
zanieb opened this issue May 21, 2024 · 2 comments · Fixed by #3987
Closed

Deadlock during resolution #3724

zanieb opened this issue May 21, 2024 · 2 comments · Fixed by #3987
Labels
bug Something isn't working help wanted Contribution especially encouraged

Comments

@zanieb
Copy link
Member

zanieb commented May 21, 2024

We're observing non-deterministic deadlocks in our test suite that we believe comes from #3627 which would mean it's present in v0.1.45+.

Please chime in if you're encountering this. We have yet to come up with a reliable reproduction.

This looks limited to Linux (Ubuntu in our test suite).
@zanieb zanieb added bug Something isn't working help wanted Contribution especially encouraged labels May 21, 2024
@ChannyClaus
Copy link
Contributor

is there a link to the deadlocked build?

@ibraheemdev ibraheemdev mentioned this issue Jun 3, 2024
Merged
ibraheemdev added a commit that referenced this issue Jun 3, 2024
@ibraheemdev
Avoid race condition in OnceMap (#3987)
1ffe18d 
## Summary

Fixes a race condition in `OnceMap::wait_blocking` where the inserted
value could potentially be missed, leading to a deadlock. Fairly certain
this will resolve #3724.
@ibraheemdev
Copy link
Member

ibraheemdev commented Jun 3, 2024 •
edited
Loading

#3987 should fix this, but we can reopen this issue if it ever appears again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Contribution especially encouraged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid race condition in OnceMap ibraheemdev/uv
3 participants
@zanieb @ChannyClaus @ibraheemdev