[flake8-pyi] Fix false negative for PYI046 with unused generic protocols #9405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| PYI046 | 2 | 2 | 0 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+2 -0 violations, +0 -0 fixes in 1 projects; 42 projects unchanged)
python/typeshed (+2 -0 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --preview --select PYI
+ stubs/openpyxl/openpyxl/xml/_functions_overloads.pyi:32:7: PYI046 Private protocol `_HasTagAndGet` is never used + stubs/protobuf/google/protobuf/internal/type_checkers.pyi:5:7: PYI046 Private protocol `_ValueChecker` is never used
Changes by rule (1 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| PYI046 | 2 | 2 | 0 | 0 | 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just fixed this false negative in flake8-pyi (PyCQA/flake8-pyi#460), and then realised ruff has the exact same bug! Luckily it's a very easy fix.
(The bug is that unused protocols go undetected if they're generic.)