Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat all typing_extensions members as typing aliases #9335

Merged
merged 1 commit into from
Dec 31, 2023
Merged

Treat all typing_extensions members as typing aliases #9335

merged 1 commit into from
Dec 31, 2023

Conversation

charliermarsh
Copy link
Member

Summary

Historically, we encoded this list by extracting the __all__. I went to update it, but... is there really any value in it? Seems easier to just treat typing_extensions as an alias for typing.

Closes #9334.

@charliermarsh charliermarsh mentioned this pull request Dec 31, 2023
Closed
@charliermarsh charliermarsh added the bug Something isn't working label Dec 31, 2023
@charliermarsh charliermarsh marked this pull request as draft December 31, 2023 16:50
@charliermarsh
Copy link
Member Author

Sorry, marking as draft, not done (but need to step out).

@charliermarsh charliermarsh marked this pull request as ready for review December 31, 2023 16:51
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@AlexWaygood
Copy link
Member

Since typing_extensions==4.7.0, we've re-exported all objects from the typing module in typing_extensions so that it can be used as a drop-in replacement for the typing module. So this makes sense to me!

@charliermarsh
Copy link
Member Author

Awesome, thank you! Gonna take that as an approval :)

@charliermarsh charliermarsh merged commit 195f7c0 into main Dec 31, 2023
17 checks passed
@charliermarsh charliermarsh deleted the charlie/ext branch December 31, 2023 18:23
@miccal miccal mentioned this pull request Jan 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb Awaiting requested review from zanieb

@konstin konstin Awaiting requested review from konstin

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive RUF013 PEP 484 prohibits implicit Optional
2 participants
@charliermarsh @AlexWaygood