Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make math-constant rule more targeted #9054

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Make math-constant rule more targeted #9054

merged 1 commit into from
Dec 8, 2023

Conversation

charliermarsh
Copy link
Member

Summary

We now only flag math.pi if the value is in [3.14, 3.15), and apply similar rules to the other constants.

Closes #9049.

@charliermarsh charliermarsh added the bug Something isn't working label Dec 8, 2023
@charliermarsh charliermarsh requested a review from zanieb December 8, 2023 16:58
@charliermarsh charliermarsh marked this pull request as ready for review December 8, 2023 16:58
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

konstin
konstin approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@konstin konstin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So i can safely continue with π=3 :P

@charliermarsh charliermarsh merged commit e043bd4 into main Dec 8, 2023
17 checks passed
@charliermarsh charliermarsh deleted the charlie/furb branch December 8, 2023 17:42
@krehel krehel mentioned this pull request Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konstin konstin konstin approved these changes

@zanieb zanieb zanieb approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FURB152 has too many false positives
3 participants
@charliermarsh @zanieb @konstin