-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support type alias statements in simple statement positions #8916
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
use crate::{lexer::LexResult, token::Tok, Mode}; | ||
use itertools::{Itertools, MultiPeek}; | ||
|
||
use crate::{lexer::LexResult, token::Tok, Mode}; | ||
|
||
/// An [`Iterator`] that transforms a token stream to accommodate soft keywords (namely, `match` | ||
/// `case`, and `type`). | ||
/// | ||
|
@@ -21,7 +22,7 @@ where | |
I: Iterator<Item = LexResult>, | ||
{ | ||
underlying: MultiPeek<I>, | ||
start_of_line: bool, | ||
position: Position, | ||
} | ||
|
||
impl<I> SoftKeywordTransformer<I> | ||
|
@@ -31,7 +32,11 @@ where | |
pub fn new(lexer: I, mode: Mode) -> Self { | ||
Self { | ||
underlying: lexer.multipeek(), // spell-checker:ignore multipeek | ||
start_of_line: !matches!(mode, Mode::Expression), | ||
position: if matches!(mode, Mode::Expression) { | ||
Position::Other | ||
} else { | ||
Position::Statement | ||
}, | ||
} | ||
} | ||
} | ||
|
@@ -59,7 +64,7 @@ where | |
// (This is to avoid treating `match` or `case` as identifiers when annotated with | ||
// type hints.) type hints.) | ||
Tok::Match | Tok::Case => { | ||
if self.start_of_line { | ||
if matches!(self.position, Position::Statement) { | ||
let mut nesting = 0; | ||
let mut first = true; | ||
let mut seen_colon = false; | ||
|
@@ -93,7 +98,10 @@ where | |
// 2. The type token is immediately followed by a name token. | ||
// 3. The name token is eventually followed by an equality token. | ||
Tok::Type => { | ||
if self.start_of_line { | ||
if matches!( | ||
self.position, | ||
Position::Statement | Position::SimpleStatement | ||
) { | ||
let mut is_type_alias = false; | ||
if let Some(Ok((tok, _))) = self.underlying.peek() { | ||
if matches!( | ||
|
@@ -132,18 +140,56 @@ where | |
} | ||
} | ||
|
||
self.start_of_line = next.as_ref().is_some_and(|lex_result| { | ||
lex_result.as_ref().is_ok_and(|(tok, _)| { | ||
if matches!(tok, Tok::NonLogicalNewline | Tok::Comment { .. }) { | ||
return self.start_of_line; | ||
// Update the position, to track whether we're at the start of a logical line. | ||
if let Some(lex_result) = next.as_ref() { | ||
if let Ok((tok, _)) = lex_result.as_ref() { | ||
match tok { | ||
Tok::NonLogicalNewline | Tok::Comment { .. } => { | ||
// Nothing to do. | ||
} | ||
Tok::StartModule | Tok::Newline | Tok::Indent | Tok::Dedent => { | ||
self.position = Position::Statement; | ||
} | ||
// If we see a semicolon, assume we're at the start of a simple statement, as in: | ||
// ```python | ||
// type X = int; type Y = float | ||
// ``` | ||
Tok::Semi => { | ||
self.position = Position::SimpleStatement; | ||
} | ||
// If we see a colon, and we're not in a nested context, assume we're at the | ||
// start of a simple statement, as in: | ||
// ```python | ||
// class Class: type X = int | ||
// ``` | ||
Tok::Colon if matches!(self.position, Position::Other) => { | ||
self.position = Position::SimpleStatement; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just looking at the colon itself might not be sufficient because colons are also used to separate type annotations, slice indices, etc). I'm not sure if this is an issue here, but let's add a few more tests, e.g. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In the logical line rules, we have some more extensive logic to ensure that the colon follows a statement keyword (like |
||
} | ||
Tok::Lpar | Tok::Lsqb | Tok::Lbrace => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: You could implement |
||
self.position = if let Position::Nested(depth) = self.position { | ||
Position::Nested(depth.saturating_add(1)) | ||
} else { | ||
Position::Nested(1) | ||
}; | ||
} | ||
Tok::Rpar | Tok::Rsqb | Tok::Rbrace => { | ||
self.position = if let Position::Nested(depth) = self.position { | ||
let depth = depth.saturating_sub(1); | ||
if depth > 0 { | ||
Position::Nested(depth) | ||
} else { | ||
Position::Other | ||
} | ||
} else { | ||
Position::Other | ||
}; | ||
} | ||
_ => { | ||
self.position = Position::Other; | ||
} | ||
} | ||
|
||
matches!( | ||
tok, | ||
Tok::StartModule | Tok::Newline | Tok::Indent | Tok::Dedent | ||
) | ||
}) | ||
}); | ||
} | ||
} | ||
|
||
next | ||
} | ||
|
@@ -161,3 +207,19 @@ fn soft_to_name(tok: &Tok) -> Tok { | |
name: name.to_owned(), | ||
} | ||
} | ||
|
||
#[derive(Debug, Clone, Copy, PartialEq, Eq)] | ||
enum Position { | ||
/// The lexer is at the start of a logical line, i.e., the start of a simple or compound statement. | ||
Statement, | ||
/// The lexer is at the start of a simple statement, e.g., a statement following a semicolon | ||
/// or colon, as in: | ||
/// ```python | ||
/// class Class: type X = int | ||
/// ``` | ||
SimpleStatement, | ||
/// The lexer is within brackets, with the given bracket nesting depth. | ||
Nested(u32), | ||
/// The lexer is some other location. | ||
Other, | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to your change: It's somewhat unfortunate that it's necessary to track whether we're at the start of the line, because we already know this inside of the
Lexer
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely. Perhaps we could move this into the lexer...