Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable auto-return-type involving Optional and Union annotations #8885

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Enable auto-return-type involving Optional and Union annotations #8885

merged 1 commit into from
Nov 29, 2023

Conversation

charliermarsh
Copy link
Member

Summary

Previously, this was only supported for Python 3.10 and later, since we always use the PEP 604-style unions.

@charliermarsh charliermarsh added the rule Implementing or modifying a lint rule label Nov 29, 2023
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

dhruvmanila
dhruvmanila approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty cool!

@charliermarsh charliermarsh merged commit 6435e4e into main Nov 29, 2023
17 checks passed
@charliermarsh charliermarsh deleted the charlie/union branch November 29, 2023 02:35
@miccal miccal mentioned this pull request Dec 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees
No one assigned
Labels
rule Implementing or modifying a lint rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charliermarsh @dhruvmanila