Update E402
to work at cell level for notebooks
#8872
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
E402
rule to work at cell level for Jupyter notebooks. This is enabled only in preview to gather feedback.The implementation basically resets the import boundary flag on the semantic model when we encounter the first statement in a cell.
Another potential solution is to introduce
E403
rule that is specifically for notebooks that works at cell level whileE402
will be disabled for notebooks.Test Plan
Add a notebook with imports in multiple cells and verify that the rule works as expected.
resolves: #8669