Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid E703 for last expression in a cell #8821

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

dhruvmanila
Copy link
Member

Summary

This PR updates the E703 rule to avoid flagging any semicolons if they're present after the last expression in a notebook cell. These are intended to hide the cell output.

Part of #8669

Test Plan

Add test notebook and update the snapshots.

@dhruvmanila dhruvmanila added the rule Implementing or modifying a lint rule label Nov 22, 2023
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@dhruvmanila dhruvmanila merged commit 8365d2e into main Nov 23, 2023
17 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/notebook-e703 branch November 23, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rule Implementing or modifying a lint rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants